Make command-line arguments -i "" launch the portable instance#2341
Merged
Holt59 merged 2 commits intoModOrganizer2:masterfrom Apr 27, 2026
Merged
Make command-line arguments -i "" launch the portable instance#2341Holt59 merged 2 commits intoModOrganizer2:masterfrom
Holt59 merged 2 commits intoModOrganizer2:masterfrom
Conversation
JonathanFeenstra
force-pushed
the
cmd-portable
branch
from
1a07bcc to
a4e3a07
Compare
JonathanFeenstra
changed the title
Member
|
Were you able to test if this distinguishes between no param and empty string? Could we use |
Member
Author
Yes, I confirmed it's working correctly for both
I tried |
Member
|
If this was tested I'm happy with it |
Al12rs
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1633
The check for
-iwith no arguments doesn't distinguish between-i ""or just-i:modorganizer/src/commandline.cpp
Lines 224 to 225 in 2043d99
So if we want-i ""to also launch the portable instance, we need to find another way to distinguish between those cases. I don't think we really need that though.I changed it to use
boost::optionalso we can distinguish between those cases now. @Al12rs didn't like using-i "Portable", since there could be a global instance named "Portable".